Skip to content

Handle significant whitespace before a blocks body #15692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
straight-shoota merged 2 commits into from
Apr 25, 2025
Merged

Handle significant whitespace before a blocks body #15692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
933ceca
Handle significant whitespace before a blocks body
Blacksmoke16 Apr 20, 2025
f1aa56f
Merge branch 'master' into sig-whitespace-before-block-body
straight-shoota Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions spec/compiler/parser/to_s_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,6 +624,30 @@ describe "ASTNode#to_s" do
%}
CR

expect_to_s <<-'CR', <<-'CR'
{%
({"a" => "b"} of Nil => Nil).each do |k, v|
# stuff and things
k + v

# foo bar

k + v
end
%}
CR
{%
({"a" => "b"} of Nil => Nil).each do |k, v|

k + v



k + v
end
%}
CR

expect_to_s <<-'CR'
{%
vals = "foo".strip.strip.strip
Expand Down
2 changes: 2 additions & 0 deletions src/compiler/crystal/syntax/to_s.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1195,6 +1195,8 @@ module Crystal
@str << '|'
end

write_extra_newlines node.location, node.body.location

if single_line_block
@str << ' '
node.body.accept self
Expand Down