Skip to content

Add type restrictions to benchmark directory #15688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
straight-shoota merged 2 commits into from
Aug 7, 2025
Merged

Add type restrictions to benchmark directory #15688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9b9b0c
Add missing type restrictions to benchmark directory
Vici37 Apr 20, 2025
70ed0ef
Review Comments
Vici37 Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/benchmark/bm.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,13 @@ module Benchmark
end

# Reports a single benchmark unit.
def report(label = " ", &block)
def report(label : String = " ", &block : ->) : Nil
@label_width = label.size if label.size > @label_width
@reports << {label, block}
end

# :nodoc:
def execute
def execute : Nil
if @label_width > 0
print " " * @label_width
end
Expand Down
2 changes: 1 addition & 1 deletion src/benchmark/ips.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ module Benchmark
end

# Adds code to be benchmarked
def report(label = "", &action) : Benchmark::IPS::Entry
def report(label : String = "", &action : ->) : Benchmark::IPS::Entry
item = Entry.new(label, action)
@items << item
item
Expand Down