Make offset a required parameter in Indexable#find#15671
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Apr 19, 2025
Merged
Make offset a required parameter in Indexable#find#15671straight-shoota merged 1 commit intocrystal-lang:masterfrom
offset a required parameter in Indexable#find#15671straight-shoota merged 1 commit intocrystal-lang:masterfrom
Conversation
ysbaddaden
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 1.16.0,
Indexable#findprovides theoffsetparameter as an additional feature overEnumerable#find.Calls that do not make use of this parameter don't need the added complexity of offset handling. They should fall back to the base implementation in
Enumerable#find.To achieve that, this patch makes
offseta required parameter forIndexable#find.