Skip to content

Only set up Cygwin on Windows CI if truly required#15661

Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom
HertzDevil:chore/windows-libiconv-build2
Apr 17, 2025
Merged

Only set up Cygwin on Windows CI if truly required#15661
straight-shoota merged 2 commits intocrystal-lang:masterfrom
HertzDevil:chore/windows-libiconv-build2

Conversation

@HertzDevil
Copy link
Contributor

@HertzDevil HertzDevil commented Apr 14, 2025

Extracted from #15660, this doesn't fix the issue but should greatly reduce CI noise as the majority of the affected PRs never touch the workflow definitions

@HertzDevil HertzDevil added platform:windows Windows support based on the MSVC toolchain / Win32 API topic:infrastructure/ci kind:chore labels Apr 14, 2025
@HertzDevil
Copy link
Contributor Author

This chmod: changing permissions of '.': Permission denied is really baffling since it's pretty much the final step of the build...?

@ysbaddaden ysbaddaden added this to the 1.17.0 milestone Apr 15, 2025
@straight-shoota straight-shoota merged commit 72255ab into crystal-lang:master Apr 17, 2025
35 checks passed
@HertzDevil HertzDevil deleted the chore/windows-libiconv-build2 branch April 23, 2025 15:30
@straight-shoota straight-shoota modified the milestones: 1.17.0, 1.16.2 Apr 28, 2025
@crysbot
Copy link
Collaborator

crysbot commented Apr 28, 2025

Successfully created backport PR for release/1.16:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport release/1.16 kind:chore platform:windows Windows support based on the MSVC toolchain / Win32 API topic:infrastructure/ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants