Let Crystal::EventLoop#close do the actual close (not just cleanup)#15641
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Apr 19, 2025
Merged
Conversation
Sija
reviewed
Apr 7, 2025
straight-shoota
approved these changes
Apr 15, 2025
ysbaddaden
force-pushed
the
refactor/event-loop-close
branch
from
80e93ce to
ac5ebb5
Compare
Internal refactor to have the `Crystal::EventLoop#close(io)` implementations be responsible from actually closing the file descriptor or socket, not only do some internal cleanup before closing. This will allow the io_uring event loop to close asynchronously for example.
ysbaddaden
force-pushed
the
refactor/event-loop-close
branch
from
ac5ebb5 to
4cf666d
Compare
Collaborator
Author
|
Rebased with master to remove the commit from #15640 + renamed the |
straight-shoota
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal refactor to have the
Crystal::EventLoop#close(io)implementations be responsible from actually closing the file descriptor or socket, not only do some internal cleanup before closing. They now follow the abstract methods documentation:This will allow the io_uring event loop to close asynchronously.
Adds a
#close_volatile_fd?helper on UNIX that will prove helpful in io_uring.Follow-up to #15640
Extracted from #15634