Fix libgc pkg-config name for version discovery#15636
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom Apr 15, 2025
Merged
Fix libgc pkg-config name for version discovery#15636straight-shoota merged 2 commits intocrystal-lang:masterfrom
libgc pkg-config name for version discovery#15636straight-shoota merged 2 commits intocrystal-lang:masterfrom
Conversation
straight-shoota
added
kind:bug
HertzDevil
reviewed
Apr 4, 2025
Co-authored-by: Quinton Miller <nicetas.c@gmail.com>
ysbaddaden
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We define different names for pkg-config in the
Linkannotations ofLibGCdepending on target, but used a fixed name in version discovery.This patch re-uses the name declared in the annotation. We need to filter for the appropriate annotation because there are multiple ones. Unfortunately, I haven't found an easier way to do this.