Fix: execution context queue stress test failures on CI [fixup #15345]#15630
Closed
ysbaddaden wants to merge 1 commit intocrystal-lang:masterfrom
Closed
Fix: execution context queue stress test failures on CI [fixup #15345]#15630ysbaddaden wants to merge 1 commit intocrystal-lang:masterfrom
ysbaddaden wants to merge 1 commit intocrystal-lang:masterfrom
Conversation
ysbaddaden
added
the
kind:bug
Collaborator
Author
|
Apparently that broke MinGW. While macOS somtimes doesn't like If someone has an idea to synchronize the threads... |
straight-shoota
pushed a commit
that referenced
this pull request
Sep 10, 2025
#16146) The failure happens on both x86_64 and AArch64 and happens too often on CI. An attempt to fix it didn't work (#15630). I assume macOS threads and sleeps are doing something different than the spec expects 🤷 It never happens on other platforms which should be enough to stress test the thread safety of the feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was possible for the threads to iterate 100 times and exit before the main thread had a chance to start pushing anything to the tested queue.
This might fix irregular Darwin failures on CI.
Related to #15342.