Replace deprecated LibXML.xmlGcMemSetup with .xmlMemSetup#15626
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Apr 18, 2025
Merged
Conversation
Collaborator
|
This upgrades the minimum libxml version, right? |
ysbaddaden
approved these changes
Apr 3, 2025
Member
Author
No. |
ysbaddaden
approved these changes
Apr 3, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xmlGcMemSetuphas been deprecated in libxml2 2.14 and should be replaced byxmlMemSetup(available since 2.0.0)https://gitlab.gnome.org/GNOME/libxml2/-/commit/5d36664fc91d44f1fc8426a7db6ec2400280d54c
This removes support for atomic memory allocation in libxml2, which might potentially affect GC performance.