Skip to content

Make Enum.from_value raise ArgumentError instead of Exception #15624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
straight-shoota merged 1 commit into from
Apr 18, 2025
Merged

Make Enum.from_value raise ArgumentError instead of Exception #15624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions spec/std/enum_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,15 +264,15 @@ describe Enum do
SpecEnum.from_value(0).should eq(SpecEnum::One)
SpecEnum.from_value(1).should eq(SpecEnum::Two)
SpecEnum.from_value(2).should eq(SpecEnum::Three)
expect_raises(Exception, "Unknown enum SpecEnum value: 3") { SpecEnum.from_value(3) }
expect_raises(ArgumentError, "Unknown enum SpecEnum value: 3") { SpecEnum.from_value(3) }
end

it "for flags enum" do
SpecEnumFlags.from_value(0).should eq(SpecEnumFlags::None)
SpecEnumFlags.from_value(1).should eq(SpecEnumFlags::One)
SpecEnumFlags.from_value(2).should eq(SpecEnumFlags::Two)
SpecEnumFlags.from_value(3).should eq(SpecEnumFlags::One | SpecEnumFlags::Two)
expect_raises(Exception, "Unknown enum SpecEnumFlags value: 8") { SpecEnumFlags.from_value(8) }
expect_raises(ArgumentError, "Unknown enum SpecEnumFlags value: 8") { SpecEnumFlags.from_value(8) }
end

it "for private enum" do
Expand Down
4 changes: 2 additions & 2 deletions src/enum.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,10 +446,10 @@ abstract struct Enum
# Color.from_value(0) # => Color::Red
# Color.from_value(1) # => Color::Green
# Color.from_value(2) # => Color::Blue
# Color.from_value(3) # raises Exception
# Color.from_value(3) # raises ArgumentError
# ```
def self.from_value(value : Int) : self
from_value?(value) || raise "Unknown enum #{self} value: #{value}"
from_value?(value) || raise ArgumentError.new("Unknown enum #{self} value: #{value}")
end

# Returns `true` if the given *value* is an enum member, otherwise `false`.
Expand Down