Add thread safety to at_exit#15598
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Mar 27, 2025
Merged
Conversation
Member
How would that cause any concurrent mutation? |
straight-shoota
approved these changes
Mar 25, 2025
Qard
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protects the
@@handlersclass variable ofCrystal::AtExitHandlerswith a thread mutex.Avoids a parallel initialization that could create two distinct arrays, and lose one
at_exithandler;Avoids a parallel mutation of the array when
at_exitis called in parallel to running the handlers,or whenIn these edge cases, the handler is merely added and will be run next.at_exitis called by anat_exithandler 🤷There should be no behavior change from not using the mutex compared to ST.
I didn't branch based on the
preview_mtflag because the Mutex should usually not be contended and its impact be negligible overall. That allowed to keep the implementation simple.