Respect --mcpu=help in the compiler#15595
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Mar 26, 2025
Merged
Respect --mcpu=help in the compiler#15595straight-shoota merged 1 commit intocrystal-lang:masterfrom
--mcpu=help in the compiler#15595straight-shoota merged 1 commit intocrystal-lang:masterfrom
Conversation
ysbaddaden
approved these changes
Mar 24, 2025
straight-shoota
approved these changes
Mar 24, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing
--mcpu=helpwhen building or running any Crystal source code makes LLVM display a list of all valid CPU and feature flags for the currently selected target, but then Crystal will continue with the semantic phase before failing to create a target machine for an invalid CPU. This PR makes the CLI immediately exit instead when that happens.--mattr=+helpcan be used to display the same help message without exiting the compiler nor adding an invalid feature flag; nothing needs to be done in Crystal about this.