Skip to content

Optimize Path#relative_to? #15594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
straight-shoota merged 2 commits into from
Mar 26, 2025
Merged

Optimize Path#relative_to? #15594

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60d9616
Optimize `Path#relative_to?`
HertzDevil Mar 24, 2025
8233793
fixup
HertzDevil Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/path.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1009,7 +1009,7 @@ struct Path
target_part = target_iterator.next
end

path = new_instance("")
parts = [] of String

# base_path is not consumed, so we go up before descending into target_path
if base_part.is_a?(String)
Expand All @@ -1019,21 +1019,21 @@ struct Path
return nil
end

path /= ".." unless base_part == "."
parts << ".." unless base_part == "."
base_iterator.each do
path /= ".."
parts << ".."
end
end

# target_path is not consumed, so we append what's left to the relative path
if target_part.is_a?(String)
path /= target_part
parts << target_part
target_iterator.each do |part|
path /= part
parts << part
end
end

path
new_instance(parts.join(separators[0]))
end

# :ditto:
Expand Down