ARM: reduce duplication in fiber context switch#15585
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Mar 24, 2025
Merged
Conversation
straight-shoota
approved these changes
Mar 21, 2025
ysbaddaden
deleted the
refactor/reduce-duplication-in-arm-context-switch
branch
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of copy-pasting the ASM twice (and twice again for LLVM < 9), we can put a few macros in the ASM string to conditionally generate the floating-point instructions.
Note: this likely only works because the ASM is within a wrapping macro, all the macros get resolved and only then does the compiler notices the
asmdirective.