Skip to content

Never remove UNC share name in Path#dirname#15583

Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom
HertzDevil:bug/windows-path-unc
Mar 24, 2025
Merged

Never remove UNC share name in Path#dirname#15583
straight-shoota merged 2 commits intocrystal-lang:masterfrom
HertzDevil:bug/windows-path-unc

Conversation

@HertzDevil
Copy link
Contributor

Fixes #15580.

@HertzDevil HertzDevil added kind:bug A bug in the code. Does not apply to documentation, specs, etc. platform:windows Windows support based on the MSVC toolchain / Win32 API topic:stdlib:files labels Mar 21, 2025
@straight-shoota straight-shoota added this to the 1.16.0 milestone Mar 21, 2025
@HertzDevil HertzDevil moved this to Review in Windows Support Mar 21, 2025
@straight-shoota straight-shoota merged commit 3610ea4 into crystal-lang:master Mar 24, 2025
31 of 32 checks passed
@github-project-automation github-project-automation bot moved this from Review to Done in Windows Support Mar 24, 2025
@HertzDevil HertzDevil deleted the bug/windows-path-unc branch March 24, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:bug A bug in the code. Does not apply to documentation, specs, etc. platform:windows Windows support based on the MSVC toolchain / Win32 API topic:stdlib:files

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Path#parent can strip UNC share from its server

2 participants