Skip to content

Add uninitialized variables to formatter variable scopes #15578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
straight-shoota merged 1 commit into from
Mar 24, 2025
Merged

Add uninitialized variables to formatter variable scopes #15578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions spec/compiler/formatter/formatter_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2857,6 +2857,14 @@ describe Crystal::Formatter do
def baz; end
CRYSTAL

# 15180
assert_format <<-CRYSTAL
x = uninitialized Foo
{% begin %}
x = foo(x)
{% end %}
CRYSTAL

# CVE-2021-42574
describe "Unicode bi-directional control characters" do
['\u202A', '\u202B', '\u202C', '\u202D', '\u202E', '\u2066', '\u2067', '\u2068', '\u2069'].each do |char|
Expand Down
6 changes: 5 additions & 1 deletion src/compiler/crystal/tools/formatter.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3657,7 +3657,11 @@ module Crystal
end

def visit(node : UninitializedVar)
accept node.var
var = node.var

@vars.last.add var.name if var.is_a?(Var)

accept var
skip_space_or_newline
write_token " ", :OP_EQ, " "
skip_space_or_newline
Expand Down
Loading