Extract File.match? to separate source file#15574
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Mar 22, 2025
Merged
Extract File.match? to separate source file#15574straight-shoota merged 1 commit intocrystal-lang:masterfrom
File.match? to separate source file#15574straight-shoota merged 1 commit intocrystal-lang:masterfrom
Conversation
ysbaddaden
approved these changes
Mar 20, 2025
1 task
antondalgren
added a commit
to antondalgren/crystal
that referenced
this pull request
Jan 23, 2026
I decided to go with #protocol and protocols instead of subprotocols as was selected in crystal-lang#16574. The decision was based on the JavaScript WebSocket API which uses #protocol to read the negotiated subprotocol, if any. Part of crystal-lang#15574
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation of
File.match?is a distinct algorithm and not directly related to the rest offile.cr.Extracting it to its own file ensures better separation of concerns and focus on individual features.