Add Indexable#find and #find!

[punteek]

Added implementation and tests for find and find! in Indexable, as discussed in this issue: #14642

[HertzDevil]

This failure:

Failures:

  1) Enumerable find doesn't find with default value
     Failure/Error: [1, 2, 3].find(-1) { |x| x > 3 }.should eq(-1)

       Expected: -1
            got: nil

     # spec/std/enumerable_spec.cr:545

is because it is now calling Indexable#find(offset : Int = 0, if_none = nil, & : T ->), i.e.

Find an element greater than 3 starting from offset -1, otherwise return nil,

instead of the existing Enumerable#find(if_none = nil, & : T ->), i.e.

Find an element greater than 3 starting from the first element, otherwise return -1.

offset as a positional parameter should go after if_none.

[Fryguy]

With 2 integers as positional parameters, it feels hard to read...I'm wondering if offset should be a forced keyword arg.

[Sija]

@Fryguy There's just one: offset, if_none has an arbitrary type.

[punteek]

re-ordered the parameters

[punteek]

Are there any other suggestions to this PR?

[Sija]

LGTM ❤️

[punteek]

Couple of questions on the rest of the process for PR check in:

1. Do the MinGW-w64 CI failing checks need to be passing for this PR to be merged?
2. Once all checks are passing and there are 2 approvers, does the PR automatically merge? Or will someone manually merge this branch in?
3. What does the process look like to add the new find and find! methods to documentation? Ideally that update would come alongside merging this PR

Thanks!

[Sija]

1. Do the MinGW-w64 CI failing checks need to be passing for this PR to be merged?

I don't think so, since these failures are unrelated to this PR.

2. Once all checks are passing and there are 2 approvers, does the PR automatically merge? Or will someone manually merge this branch in?

Merging is a manual process. Mind you, only approvals from the team members are counted towards the required number (and I'm not part of the Core Team).

3. What does the process look like to add the new find and find! methods to documentation? Ideally that update would come alongside merging this PR

Documentation is auto-generated based on the public API docs, so there's nothing more to do (as you've already documented the newly added methods).