Add test for HTTP::Request with resource string //#15546
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom May 4, 2025
Merged
Add test for HTTP::Request with resource string //#15546straight-shoota merged 1 commit intocrystal-lang:masterfrom
HTTP::Request with resource string //#15546straight-shoota merged 1 commit intocrystal-lang:masterfrom
Conversation
miry
commented
Mar 9, 2025
Member
|
I think going from I might even question whether it makes a lot of sense to parse this through So anyway for this PR I think we should just change the expected value to match the actual one and then we're good. |
7f59ac1 to
a9e16e4
Compare
a9e16e4 to
7da7738
Compare
straight-shoota
approved these changes
Mar 13, 2025
bcardiff
approved these changes
May 1, 2025
HTTP::Request path //
HTTP::Request path //HTTP::Request with resource string //
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing the
awscr-signerlibrary job, I noticed a change in the behavior ofHTTP::Request#pathwhen handling the case of//:Old behavior:
New behavior:
I am trying to add more tests to cover changes from #15499