Skip to content

Use binary search to search DWARF line numbers #15539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
straight-shoota merged 1 commit into from
Mar 4, 2025
+6 −22
Merged

Use binary search to search DWARF line numbers #15539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 6 additions & 22 deletions src/crystal/dwarf/line_numbers.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,33 +176,17 @@ module Crystal
@offset = @io.tell
@matrix = Array(Array(Row)).new
decode_sequences(size)

@matrix.sort_by!(&.first.address)
end

# Returns the `Row` for the given Program Counter (PC) address if found.
def find(address)
matrix.each do |rows|
if row = rows.first?
next if address < row.address
end

if row = rows.last?
next if address > row.address
end

rows.each_with_index do |current_row, index|
if current_row.address == address
return current_row
end

if address < current_row.address
if previous_row = rows[index - 1]?
return previous_row
end
end
end
end
rows = matrix.bsearch { |r| r.last.address >= address } || return
return unless address >= rows.first.address

nil
next_row_index = rows.bsearch_index { |row| row.address > address } || rows.size
rows[next_row_index - 1]
end

# Decodes the compressed matrix of addresses to line numbers.
Expand Down