Read all DWARF abbreviations tables in a single pass#15515
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Feb 26, 2025
Merged
Read all DWARF abbreviations tables in a single pass#15515straight-shoota merged 1 commit intocrystal-lang:masterfrom
straight-shoota merged 1 commit intocrystal-lang:masterfrom
Conversation
straight-shoota
approved these changes
Feb 25, 2025
ysbaddaden
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids the need to reseek the executable
IOfor every single DWARF unit header, which can considerably speed up the debug info loader for large binaries, such as the Crystal compiler itself. The following are the mean run times forload_debug_info_implsampled by running a locally builtx86_64-linux-gnuCrystal compiler 100 times each, forcing the load on program startup withCRYSTAL_LOAD_DEBUG_INFO=1:There are no significant improvements on
x86_64-windows-gnu. I'm unsure why. It however does wonders on WSL2 Debian when the executable is on a Windows filesystem:For the record, the times are printed using:
Release builds are largely unaffected because their abbreviations tables are extremely small, even with
--debugpassed.