RFC 2: Add Fiber::ExecutionContext::SingleThreaded scheduler#15511
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom Mar 17, 2025
Merged
Conversation
Introduces the first EC scheduler that runs in a single thread. Uses the same queues (Runnables, GlobalQueue) as the multi-threaded scheduler that will come next. The Runnables local queue could be simplified (no parallel accesses, hence no need for atomics) at the expense of duplicating the implementation. The scheduler doesn't need to actively park the thread; the event loops always block (when told to) even when there are no events, which acts as parking the thread.
ysbaddaden
commented
Feb 24, 2025
ysbaddaden
changed the title
ysbaddaden
commented
Feb 25, 2025
Co-authored-by: Johannes Müller <straightshoota@gmail.com>
ysbaddaden
changed the title
straight-shoota
approved these changes
Mar 14, 2025
straight-shoota
changed the title
Fiber::ExecutionContext::SingleThreaded scheduler
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces the first EC scheduler that runs in a single thread.
Uses the same queues (
Runnables,GlobalQueue) as the multithreaded scheduler that will come next. TheRunnableslocal queue could be simplified (no parallel accesses, hence no need for atomics) at the expense of duplicating the implementation.The scheduler doesn't need to actively park the thread; the event loops always block (when told to) even when there are no events, which acts as parking the thread.
NOTE: we can start running the specs in this context (they pass locally), though there might be some issues until we replace rogue
Threadinstances with bubble wrappedExecutionContext::Isolated(coming in another PR). If you wanna try:Refs #15342