Add function name to CRYSTAL_DEBUG_CODEGEN log helper#15506
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Feb 23, 2025
Merged
Conversation
straight-shoota
approved these changes
Feb 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When diagnosing bad code generation, it is helpful to know whether a program actually reached an
unreachableinstruction, because this is usually where observable undefined behavior stems from. There is already a little-known way, which is setting the environment variableCRYSTAL_DEBUG_CODEGEN=1:The log includes the LLVM basic block name, as well as the source location of the compiler call that builds the
unreachable. However, this is insufficient to pinpoint theunreachablein the LLVM IR, since the block name can be something very generic, e.g.entryorcurrent_def3. This PR adds the LLVM function name as well; all functions have unique names, as do basic blocks within a single function. The above now prints: