Refactor extract HTTP::Cookies to its own file#15500
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom Feb 22, 2025
Merged
Refactor extract HTTP::Cookies to its own file#15500straight-shoota merged 2 commits intocrystal-lang:masterfrom
HTTP::Cookies to its own file#15500straight-shoota merged 2 commits intocrystal-lang:masterfrom
Conversation
ysbaddaden
approved these changes
Feb 21, 2025
straight-shoota
changed the title
HTTP::Cookies to its own fileHTTP::Cookies to its own file
kojix2
pushed a commit
to kojix2/crystal
that referenced
this pull request
Feb 23, 2025
`HTTP::Cookies` is a separate concern from `HTTP::Cookie` and should have its own file space. `Cookie::Parser` could also be extracted, but it's more closely related and there are plans for a bigger overhaul/refactor in crystal-lang#15218.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTP::Cookiesis a separate concern fromHTTP::Cookieand should have its own file space.Cookie::Parsercould also be extracted, but it's more closely related and there are plans for a bigger overhaul/refactor in #15218.