Support sizeof and alignof inside macros for stable types#15497
Merged
straight-shoota merged 3 commits intocrystal-lang:masterfrom Mar 19, 2025
Merged
Support sizeof and alignof inside macros for stable types#15497straight-shoota merged 3 commits intocrystal-lang:masterfrom
sizeof and alignof inside macros for stable types#15497straight-shoota merged 3 commits intocrystal-lang:masterfrom
Conversation
straight-shoota
approved these changes
Mar 17, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables the use of
sizeofandalignofin macro expressions when the type's size and alignment are known to be stable, i.e. their values cannot be changed by adding new code. The idea was raised in this forum thread and possibly in other GitHub issues as well. With this PR you can write compile-time checks like:{% unless sizeof(Void*) == sizeof(LibC::SizeT) %} {% raise "we don't allow the x86 Real Mode here" %} {% end %}All types are stable, except for the following:
BytesReferenceStorageinstancesGC(not to be confused withGC.class, all metaclasses are stable)Arrayx = uninitialized Flags(these "types" are ill-behaved anyway)StaticArray,Tuple,NamedTuple, andUnioninstances containing any unstable constituent typestypeofis disallowed, because we obviously cannot do any kind of non-macro semantic analysis inside macros.Although the non-macro
sizeofandalignofsupport constants, their macro counterparts do not, even when constant evaluates to a simple compile-time literal (A = 1; {{ sizeof(A) }}).