Remove unnecessary calls to Crystal::CodeGenVisitor#union_type_and_value_pointer#15491
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Feb 21, 2025
Conversation
straight-shoota
approved these changes
Feb 20, 2025
ysbaddaden
approved these changes
Feb 20, 2025
kojix2
pushed a commit
to kojix2/crystal
that referenced
this pull request
Feb 23, 2025
…alue_pointer` (crystal-lang#15491) `#union_type_and_value_pointer` always emits a pair of `getelementptr` LLVM instructions, even when the caller is not interested in the pointer to a mixed union value's type ID or data. This PR eliminates those redundant `getelementptr`s.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#union_type_and_value_pointeralways emits a pair ofgetelementptrLLVM instructions, even when the caller is not interested in the pointer to a mixed union value's type ID or data. This PR eliminates those redundantgetelementptrs.