Do not load Path call receiver if known to be pure load#15488
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Feb 21, 2025
Merged
Do not load Path call receiver if known to be pure load#15488straight-shoota merged 1 commit intocrystal-lang:masterfrom
Path call receiver if known to be pure load#15488straight-shoota merged 1 commit intocrystal-lang:masterfrom
Conversation
straight-shoota
approved these changes
Feb 20, 2025
kojix2
pushed a commit
to kojix2/crystal
that referenced
this pull request
Feb 23, 2025
…15488) The compiler always emits LLVM instructions to load the receiver of a call even if it has a metaclass type, because there could be other side effects. This adds a large number of superfluous type ID loads when calling class methods: ```llvm %0 = load i32, ptr @"Foo0.class:type_id", align 4 %1 = call ptr @"*Foo0@Reference::new:Foo0"() %2 = load i32, ptr @"Foo1.class:type_id", align 4 %3 = call ptr @"*Foo1@Reference::new:Foo1"() %4 = load i32, ptr @"Foo2.class:type_id", align 4 %5 = call ptr @"*Foo2@Reference::new:Foo2"() ; ... ``` Although `.new` does load the type ID later, this ID should never show up as an implicit argument to the `Foo*.new` methods. Here the `%0`, `%2`, and `%4` variables are a consequence of un-inlining the type IDs. This patch removes those loads when the call receiver is a `Path` known to refer to a non-generic metaclass type. (In isolation, the path skips over whatever is in `Crystal::CodeGenVisitor#visit(Crystal::Path)`.)
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #15485.
The compiler always emits LLVM instructions to load the receiver of a call even if it has a metaclass type, because there could be other side effects. This adds a large number of superfluous type ID loads when calling class methods:
Although
.newdoes load the type ID later, this ID should never show up as an implicit argument to theFoo*.newmethods. Here the%0,%2, and%4variables are a consequence of un-inlining the type IDs. This PR removes those loads when the call receiver is aPathknown to refer to a non-generic metaclass type. (In isolation, the PR skips over whatever is inCrystal::CodeGenVisitor#visit(Crystal::Path).)