Skip to content

Add locations to When nodes #15481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
straight-shoota merged 1 commit into from
Feb 22, 2025
Merged

Add locations to When nodes #15481

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/compiler/crystal/syntax/parser.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2834,7 +2834,9 @@ module Crystal

when_body = parse_expressions
skip_space_or_newline
whens << When.new(when_conds, when_body).at(location)
whens << When.new(when_conds, when_body)
.at(location)
.at_end(when_conds.last.end_location)
when Keyword::ELSE
if exhaustive
raise "exhaustive case (case ... in) doesn't allow an 'else'"
Expand Down Expand Up @@ -2990,6 +2992,8 @@ module Crystal
skip_space_or_newline

whens << When.new(condition, body)
.at(location)
.at_end(condition.end_location)
when Keyword::ELSE
if whens.size == 0
unexpected_token "expecting when"
Expand Down