Skip to content

[CI] Filter runs of OpenSSL Test workflow #15459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
straight-shoota merged 1 commit into from
Feb 13, 2025
Merged

[CI] Filter runs of OpenSSL Test workflow #15459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion .github/workflows/openssl.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,21 @@
name: OpenSSL CI

on: [push, pull_request]
on:
push:
paths:
- 'src/openssl/**'
- 'spec/std/digest/**'
- 'spec/std/openssl/**'
- '.github/workflows/openssl.yml'
pull_request:
paths:
- 'src/openssl/**'
- 'spec/std/digest/**'
- 'spec/std/openssl/**'
- '.github/workflows/openssl.yml'
schedule:
- cron: '0 3 * * *'
Copy link
Contributor

@Sija Sija Feb 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it would be a good idea to set the schedule to a bit different time for each of the workflows to avoid CI congestion and potentially speed up the runs.

Copy link
Member Author

@straight-shoota straight-shoota Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we have had this discussion before. But I don't recall where.

Congestion isn't that bad. These workflows are now running only once per day, not on every commit (often even twice per).

Speed up isn't really relevant here. We just want them to run at some point in a regular interval. Doesn't matter much when exactly.

In fact, I'm considering to introduce a central orchestration workflow which runs on a schedule and calls the other ones (mentioned in #14983 (comment)). At that point all workflows would be triggered at the same time anyway.

workflow_dispatch:

permissions: {}

Expand Down
Loading