Rename find-llvm-config to find-llvm-config.sh#15448
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Feb 21, 2025
Merged
Rename find-llvm-config to find-llvm-config.sh#15448straight-shoota merged 1 commit intocrystal-lang:masterfrom
find-llvm-config to find-llvm-config.sh#15448straight-shoota merged 1 commit intocrystal-lang:masterfrom
Conversation
ysbaddaden
approved these changes
Feb 20, 2025
straight-shoota
added a commit
to straight-shoota/crystal
that referenced
this pull request
Feb 21, 2025
kojix2
pushed a commit
to kojix2/crystal
that referenced
this pull request
Feb 23, 2025
This patch renames this helper script to express its type in the filename. It is only used internally in this repo, so I don't think this rename should have any negative effect. Ref. https://github.com/crystal-lang/crystal/pull/15169/files#r1950930791
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch renames this helper script to express its type in the filename.
It is only used internally in this repo, so I don't think this rename should have any negative effect.
Ref. https://github.com/crystal-lang/crystal/pull/15169/files#r1950930791