Makefile: Expand DESTDIR outside of prefixed dir variables#15444
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Feb 11, 2025
Merged
Conversation
ysbaddaden
approved these changes
Feb 10, 2025
Contributor
|
This is also applicable to Shards |
straight-shoota
changed the title
DESTDIR outside of prefixed dir variablesDESTDIR outside of prefixed dir variables
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per convention,
DESTDIRshould only be expanded directly in the install/uninstall targets, not prefixed into the directory variables.