Fix Tuple#to_a(&) for arbitrary block output type#15431
Merged
straight-shoota merged 3 commits intocrystal-lang:masterfrom Feb 8, 2025
Merged
Fix Tuple#to_a(&) for arbitrary block output type#15431straight-shoota merged 3 commits intocrystal-lang:masterfrom
Tuple#to_a(&) for arbitrary block output type#15431straight-shoota merged 3 commits intocrystal-lang:masterfrom
Conversation
straight-shoota
added
kind:bug
straight-shoota
commented
Feb 7, 2025
Comment on lines
-548
to
-552
| {% if compare_versions(Crystal::VERSION, "1.1.0") < 0 %} | ||
| to_a(&.itself.as(Union(*T))) | ||
| {% else %} | ||
| to_a(&.itself) | ||
| {% end %} |
Member
Author
There was a problem hiding this comment.
With this change, the explicit cast here is always necessary, even after 1.1.0 because the compiler couldn't figure out the output type of &.itself.
ysbaddaden
approved these changes
Feb 7, 2025
straight-shoota
changed the title
Tuple#to_a(&) for arbitrary block output type
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #15430