Add @[Linkage("value")] annotation (applies to fun)#15426
Closed
ysbaddaden wants to merge 4 commits intocrystal-lang:masterfrom
Closed
Add @[Linkage("value")] annotation (applies to fun)#15426ysbaddaden wants to merge 4 commits intocrystal-lang:masterfrom
@[Linkage("value")] annotation (applies to fun)#15426ysbaddaden wants to merge 4 commits intocrystal-lang:masterfrom
Conversation
The annotation can be specified on fun definitions (with a body). Incidently it can also be specified to extern fun in lib declarations (without a body) in which case LLVM may only accept a few values (external, weak). The linkage is only set during codegen when `--single-module` is set, since otherwise it would prevent any module from calling funs that are always declared in the `main` module.
Member
|
It would be nice to have a spec for this. This should be quite trivial: Build a binary which includes a fun with |
straight-shoota
approved these changes
Feb 7, 2025
straight-shoota
approved these changes
Feb 7, 2025
Collaborator
Author
|
I added a spec that checks if the linkage as been correctly set on the LLVM bitcode. That only tests the intended behavior, not that the linked binary behaves as expected, but it avoids having to find alternatives to |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declares a new compiler annotation,
Linkage, that may take one of the following values:"external"—the symbol is referenced in the object file and is visible to all symbols from all object files (this is the default)."internal"—the symbol will be referenced in the object file, but is only visible to symbols within that object only.The annotation can only be specified on
fundefinitions (with a body). Incidentally it can also be specified to externfuninlibdeclarations (without a body), though the only value accepted by LLVM will beexternaland a few other values (not implemented).I chose to limit the possible values, and not expose all values from
LLVM::Linkage. We should have a proper discussion about adding more. For example we might consider theweakvalue in a future development, but we'll need to correctly define what we mean with "weak" linkage (there are multiple definitions).Related to #921