Fix argument type for EVP_CIPHER_get_flags#15392
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Feb 1, 2025
Merged
Fix argument type for EVP_CIPHER_get_flags#15392straight-shoota merged 1 commit intocrystal-lang:masterfrom
EVP_CIPHER_get_flags#15392straight-shoota merged 1 commit intocrystal-lang:masterfrom
Conversation
Per OpenSSL documentation [^1] and the usage of `LibCrypto#evp_cipher_flags`, `EVP_CIPHER_get_flags` should accept `EVP_CIPHER` rather than `EVP_CIPHER_CTX`. An example of this usage can be seen in `OpenSSL::Cipher#authenticated?`. This change does not introduce any functional impact but improves clarity by correctly reflecting the expected argument, reducing the need for developers to cross-check other sources. [^1]: https://docs.openssl.org/1.1.1/man3/EVP_EncryptInit/#synopsis
straight-shoota
approved these changes
Jan 31, 2025
straight-shoota
added
kind:bug
ysbaddaden
approved these changes
Jan 31, 2025
straight-shoota
changed the title
EVP_CIPHER_get_flags
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per OpenSSL documentation 1 and the usage of
LibCrypto#evp_cipher_flags,EVP_CIPHER_get_flagsshould acceptEVP_CIPHERrather thanEVP_CIPHER_CTX.An example of this usage can be seen in
OpenSSL::Cipher#authenticated?2.This change does not introduce any functional impact but improves clarity by correctly reflecting the expected argument, reducing the need for developers to cross-check other sources.
Footnotes
https://docs.openssl.org/1.1.1/man3/EVP_EncryptInit/#synopsis ↩
https://github.com/crystal-lang/crystal/blob/2978cd157a7a24a68abcc6d41a12dd7f04afc1f5/src/openssl/cipher.cr#L156C7-L156C21 ↩