Fix GC sig_suspend, sig_resume for gc_none#15349
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Jan 17, 2025
Merged
Conversation
The gc_none interface doesn't define the `sig_suspend` nor `sig_resume` class methods. The program should still compile but commit 57017f6 improperly checks for the method existence, and the methods are always required and the fallback never used.
ysbaddaden
added
topic:stdlib:system
kind:regression
straight-shoota
approved these changes
Jan 16, 2025
straight-shoota
changed the title
sig_suspend, sig_resume for gc_none
Contributor
|
Successfully created backport PR for |
straight-shoota
added
the
kind:bug
Collaborator
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release/1.15
git worktree add -d .worktree/backport-15349-to-release/1.15 origin/release/1.15
cd .worktree/backport-15349-to-release/1.15
git switch --create backport-15349-to-release/1.15
git cherry-pick -x 0fbdcc90f1e907995671a4387fcc22f957321d61 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gc_none interface doesn't define the
sig_suspendnorsig_resumeclass methods. The program should still compile but commit 57017f6 improperly checks for the method existence, and the methods are always required and compilation fails.The following is enough to reproduce:
Closes ysbaddaden/gc#32