Explicit exit from main#15299
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom Dec 25, 2024
Merged
Conversation
In a MT environment the main thread's fiber may be resumed by any thread, which may terminate the program, and would return from another thread that the process' main thread, which may be This patches instead explicitly exits from `main` and `wmain`. For backward compatibility reason (win32's `wmain` and wasi's `__main_argc_argv` call `main`), the default `main` still returns, and is replaced for UNIX targets.
ysbaddaden
commented
Dec 20, 2024
ysbaddaden
commented
Dec 20, 2024
straight-shoota
approved these changes
Dec 20, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a MT environment such as proposed in crystal-lang/rfcs#2, the main thread's fiber may be resumed by any thread, and it may return which would terminate the program... but it might return from another thread that the process' main thread, which may be unexpected by the OS.
This patch instead explicitly exits from
mainandwmain.For backward compatibility reasons (win32
wmainand wasi__main_argc_argvboth callmainandand are documented to do so), the defaultmainstill returns, but is being replaced for UNIX targets by one that exits.Maybe the OS actual entrypoint could merely call
Crystal.maininstead ofmainand explicitely exit (there wouldn't be a globalmainexcept forUNIX), but this is out of scope for this PR.