Add Path as possible argument type to UNIXSocket and UNIXServer#15260
Merged
straight-shoota merged 5 commits intocrystal-lang:masterfrom Jan 13, 2025
Merged
Add Path as possible argument type to UNIXSocket and UNIXServer#15260straight-shoota merged 5 commits intocrystal-lang:masterfrom
Path as possible argument type to UNIXSocket and UNIXServer#15260straight-shoota merged 5 commits intocrystal-lang:masterfrom
Conversation
Sija
reviewed
Dec 9, 2024
Member
|
The linker error might be due to #13193 |
straight-shoota
approved these changes
Dec 9, 2024
Contributor
Author
|
Yep, can confirm installing |
ysbaddaden
approved these changes
Jan 6, 2025
straight-shoota
changed the title
Path as possible argument type to UNIXSocket and UNIXServerPath as possible argument type to UNIXSocket and UNIXServer
straight-shoota
changed the title
Path as possible argument type to UNIXSocket and UNIXServerPath as possible argument type to UNIXSocket and UNIXServer
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As outlined in #15259,
UNIXSocket,UNIXServerandUNIXAddressshould acceptPath | String, likeFiledoes.I based the implementation off that in File.
I couldn't run the specs due to some obscure error though, but for FWIW that fails for me on 1.15-dev and 1.14.0 without these changes as well 🤷
Resolves #15259