Change libevent event loop to wait forever when blocking#15243
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Dec 4, 2024
Merged
Conversation
Contributor
|
I believe you could now also drop the Windows interpreter-only idle loop in |
Collaborator
Author
|
@HertzDevil That would be after #15238 won't it? |
Member
|
Could we separate this into two PRs? |
yxhuvud
reviewed
Dec 3, 2024
ysbaddaden
force-pushed
the
feature/evloop-libevent-block-forever
branch
from
c002dff to
4a670f6
Compare
straight-shoota
approved these changes
Dec 3, 2024
straight-shoota
changed the title
libevent event loop to wait forever when blocking
This was referenced Dec 3, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #14949 but with a twist:the libevent evloop no longer returns when it's empty (no queued events), so the behavior doesn't rely on the existence of the stack-pool-collector fiber repeatedly sleeping.The Polling evloop already waits forever (when blocking) and IOCP will also with #15238.
edit: extracted drop fiber channel commit.