Introduce Crystal::EventLoop namespace#15226
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Dec 1, 2024
Merged
Introduce Crystal::EventLoop namespace#15226straight-shoota merged 1 commit intocrystal-lang:masterfrom
Crystal::EventLoop namespace#15226straight-shoota merged 1 commit intocrystal-lang:masterfrom
Conversation
ysbaddaden
changed the title
Collaborator
Author
|
I hope nobody has a branch with lots of changes for an event loop 😅 |
The current event loops are scattered a bit everywhere, or buried inside `src/crystal/system/x` when they don't use the `Crystal::System` namespace. This patch groups all the implementations under `Crystal::EventLoop` in `src/crystal/event_loop`. Of course the actual system parts are kept in (or moved to) `Crystal::System`. - `Crystal::Evented::EventLoop` => `Crystal::EventLoop::Polling` (abstract) - `Crystal::Epoll::EventLoop` => `Crystal::EventLoop::Epoll` - `Crystal::Kqueue::EventLoop` => `Crystal::EventLoop::Kqueue` - `Crystal::LibEvent::EventLoop` => `Crystal::EventLoop::LibEvent` - `Crystal::IOCP::EventLoop` => `Crystal::EventLoop::IOCP` - `Crystal::IOCP` => `Crystal::System::IOCP` A new evloop, for example `io_uring`, would naturally be implemented as `Crystal::EventLoop::IoUring`.
ysbaddaden
force-pushed
the
feature/crystal-event-loop-namespace
branch
from
1032790 to
c5bba26
Compare
straight-shoota
approved these changes
Nov 28, 2024
straight-shoota
changed the title
Crystal::EventLoop namespace
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The event loop implementations are scattered a bit everywhere, or buried inside
src/crystal/system/oswhen they don't use theCrystal::Systemnamespace at all.This patch groups all the implementations under
Crystal::EventLoopinsrc/crystal/event_loop. Of course the system parts are kept in (or moved to)Crystal::System.Crystal::Evented::EventLoop=>Crystal::EventLoop::Polling(abstract)Crystal::Epoll::EventLoop=>Crystal::EventLoop::EpollCrystal::Kqueue::EventLoop=>Crystal::EventLoop::KqueueCrystal::LibEvent::EventLoop=>Crystal::EventLoop::LibEventCrystal::IOCP::EventLoop=>Crystal::EventLoop::IOCPCrystal::IOCP=>Crystal::System::IOCPA new evloop, for example
io_uring, would naturally be implemented asCrystal::EventLoop::IoUring.Builds on top of #15206. See commit 5cd85da.