Add compiler path to $PATH and $CRYSTAL_EXEC_PATH for subcommands#15186
Conversation
13afe7e to
c8d8a61
Compare
|
I dropped the test code for |
|
An upside of the $CRYSTAL env variable is that if the compiler is not crystal but something else crystal-1.0, crystal-1.14, crystal-2 then the external commands still works. I don't mind prepending to the $PATH and having a $CRYSTAL_EXEC_PATH, but I don't see how we enable binaries named differently. $CRYSTAL is also used in shards as a convention, so I thought it was convenient to keep the same pattern. (which happens to be the same as in cabal with $CABAL) |
|
If no one thinks that supporting different names of the compiler binary is needed then 👍 |
|
The interface between the compiler and extension scripts is likely to be a long-lived interface, so I think it's worth spending the time to get it working when the compiler isn't named just |
$PATH for subcommands$PATH and $CRYSTAL_EXEC_PATH for subcommands
|
CI on mingw-w64 is failing due to #15516. |
|
The MinGW-W64 CI workflow appears to have even more issues: #15516 (comment) I might try to skip this spec then so we can move forward here. |
Resolves #15145
This patch contains a breaking change of dropping the environment variable
$CRYSTAL(introduced in #14953 1.14.0) in favour of the newly added ones.Quoting from #15145: