Handle trailing comma with multiple parameters on the same line#15097
Merged
straight-shoota merged 1 commit intocrystal-lang:release/1.14from Jan 6, 2025
Merged
Conversation
Blacksmoke16
added
kind:bug
straight-shoota
approved these changes
Oct 18, 2024
HertzDevil
approved these changes
Oct 24, 2024
Member
Author
|
Probably doesn't make sense to add this to |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is going directly into
release/1.14given with #14718 being merged,masternow enforces it so there is nothing to change anymore.Fix here was basically allowing it to write the comma if the new formatter rules says there should be one, and there is already a comma present. This makes it BC since it won't add one without either the flag, or a comma already being present.