Skip to content

Add Exception::CallStack.empty #15017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
straight-shoota merged 1 commit into from
Sep 21, 2024
+6 −5
Merged

Add Exception::CallStack.empty #15017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/compiler/crystal/semantic/call.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,8 @@ class Crystal::Call
property? uses_with_scope = false

class RetryLookupWithLiterals < ::Exception
@@dummy_call_stack = Exception::CallStack.new

def initialize
self.callstack = @@dummy_call_stack
self.callstack = Exception::CallStack.empty
end
end

Expand Down
7 changes: 5 additions & 2 deletions src/exception/call_stack.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,11 @@ struct Exception::CallStack
@callstack : Array(Void*)
@backtrace : Array(String)?

def initialize
@callstack = CallStack.unwind
def initialize(@callstack : Array(Void*) = CallStack.unwind)
end

def self.empty
new([] of Void*)
end

def printable_backtrace : Array(String)
Expand Down