Skip to content

Reduce calls to Crystal::Type#remove_indirection in module dispatch #14992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
straight-shoota merged 3 commits into from
Sep 21, 2024
Merged

Reduce calls to Crystal::Type#remove_indirection in module dispatch #14992

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d15d9ba
Reduce calls to `Crystal::Type#remove_indirection` in module dispatch
HertzDevil Sep 10, 2024
94134ff
hoist `#remove_indirection` for `downcast` too
HertzDevil Sep 10, 2024
a8153a9
fixup
HertzDevil Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/compiler/crystal/codegen/call.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,10 @@ class Crystal::CodeGenVisitor

# Create self var if available
if node_obj
new_vars["%self"] = LLVMVar.new(@last, node_obj.type, true)
# call `#remove_indirection` here so that the downcast call in
# `#visit(Var)` doesn't spend time expanding module types again and again
# (it should be the only use site of `node_obj.type`)
new_vars["%self"] = LLVMVar.new(@last, node_obj.type.remove_indirection, true)
end

# Get type if of args and create arg vars
Expand All @@ -359,6 +362,10 @@ class Crystal::CodeGenVisitor

is_super = node.super?

# call `#remove_indirection` here so that the `match_type_id` below doesn't
# spend time expanding module types again and again
owner = owner.remove_indirection unless is_super

with_cloned_context do
context.vars = new_vars

Expand Down