Fix Process.exec stream redirection on Windows#14986
Merged
straight-shoota merged 5 commits intocrystal-lang:masterfrom Sep 16, 2024
Merged
Fix Process.exec stream redirection on Windows#14986straight-shoota merged 5 commits intocrystal-lang:masterfrom
Process.exec stream redirection on Windows#14986straight-shoota merged 5 commits intocrystal-lang:masterfrom
Conversation
HertzDevil
added
kind:bug
straight-shoota
approved these changes
Sep 9, 2024
Member
straight-shoota
left a comment
straight-shoota
left a comment
There was a problem hiding this comment.
Could we get a spec for this? 🤔
Co-authored-by: Johannes Müller <straightshoota@gmail.com>
straight-shoota
approved these changes
Sep 10, 2024
straight-shoota
added a commit
that referenced
this pull request
Sep 17, 2024
The following should print the compiler help message to the file `foo.txt`:
```crystal
File.open("foo.txt", "w") do |f|
Process.exec("crystal", output: f)
end
```
It used to work on Windows in Crystal 1.12, but is now broken since 1.13. This is because `LibC._wexecvp` only inherits file descriptors in the C runtime, not arbitrary Win32 file handles; since we stopped calling `LibC._open_osfhandle`, the C runtime knows nothing about any reopened standard streams in Win32. Thus the above merely prints the help message to the standard output.
This PR creates the missing C file descriptors right before `LibC._wexecvp`. It also fixes a different regression of #14947 where reconfiguring `STDIN.blocking` always fails.
Co-authored-by: Johannes Müller <straightshoota@gmail.com>
1 task
Collaborator
|
This pull request has been mentioned on Crystal Forum. There might be relevant details there: https://forum.crystal-lang.org/t/crystal-1-13-3-is-released/7191/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following should print the compiler help message to the file
foo.txt:It used to work on Windows in Crystal 1.12, but is now broken since 1.13. This is because
LibC._wexecvponly inherits file descriptors in the C runtime, not arbitrary Win32 file handles; since we stopped callingLibC._open_osfhandle, the C runtime knows nothing about any reopened standard streams in Win32. Thus the above merely prints the help message to the standard output.This PR creates the missing C file descriptors right before
LibC._wexecvp. It also fixes a different regression of #14947 where reconfiguringSTDIN.blockingalways fails.Related: #14422