Don't involve evloop after fork in System::Process.spawn (UNIX)#14974
Merged
straight-shoota merged 6 commits intocrystal-lang:masterfrom Sep 6, 2024
Merged
Don't involve evloop after fork in System::Process.spawn (UNIX)#14974straight-shoota merged 6 commits intocrystal-lang:masterfrom
System::Process.spawn (UNIX)#14974straight-shoota merged 6 commits intocrystal-lang:masterfrom
Conversation
ysbaddaden
commented
Sep 5, 2024
This is called after fork before exec to reopen the stdio. We can leverage some abstractions (set blocking, unset cloexec) but musn't call to methods that involve the evloop and would mess with the parent evloop.
ysbaddaden
force-pushed
the
fix/unix-fork-exec
branch
from
b061503 to
72f968c
Compare
straight-shoota
approved these changes
Sep 5, 2024
straight-shoota
changed the title
System::Process.spawn (UNIX)
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors spawning child processes on UNIX that relies on fork/exec to not involve the event loop after fork and before exec. We still continue to rely on the eventloop in the parent process, of course.
Extracted from #14959 that exhibit issues with fork/exec.