Fix exponent wrapping in Math.frexp(BigFloat) for very large values#14971
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom Sep 6, 2024
Merged
Conversation
|
|
||
| # :nodoc: | ||
| struct Crystal::Hasher | ||
| def self.reduce_num(value : BigFloat) |
Member
There was a problem hiding this comment.
question: How is this removal related to the other changes?
Contributor
Author
There was a problem hiding this comment.
It too uses LibGMP.mpf_get_d_2exp, so it suffers from the same issue as Math.frexp
Member
There was a problem hiding this comment.
I see. And with its removal, calls fall back to reduce_num(value : Float) which uses Math.frexp.
straight-shoota
approved these changes
Sep 5, 2024
straight-shoota
pushed a commit
that referenced
this pull request
Sep 10, 2024
This is similar to #14971 where the base-10 exponent returned by `LibGMP.mpf_get_str` is not large enough to handle all values internally representable by GMP / MPIR.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BigFloats represent their base-256 ** sizeof(LibGMP::MpLimb)exponent with aLibGMP::MpExpfield, butLibGMP.mpf_get_d_2exponly returns the base-2 exponent as aLibC::Long, so values outside(2.0.to_big_f ** -0x80000001)...(2.0.to_big_f ** 0x7FFFFFFF)lead to an exponent overflow on Windows or 32-bit platforms:This PR fixes it by computing the exponent ourselves.