Skip to content

Fix CRT static-dynamic linking conflict in specs with C sources#14970

Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom
HertzDevil:bug/windows-spec-c-dynamic
Sep 6, 2024
Merged

Fix CRT static-dynamic linking conflict in specs with C sources#14970
straight-shoota merged 1 commit intocrystal-lang:masterfrom
HertzDevil:bug/windows-spec-c-dynamic

Conversation

@HertzDevil
Copy link
Contributor

This fixes the LINK : warning LNK4098: defaultlib 'LIBCMT' conflicts with use of other libs; use /NODEFAULTLIB:library message that shows up on Windows CI while running compiler specs.

@HertzDevil HertzDevil added kind:bug A bug in the code. Does not apply to documentation, specs, etc. platform:windows Windows support based on the MSVC toolchain / Win32 API topic:compiler:codegen labels Sep 5, 2024
@straight-shoota straight-shoota added this to the 1.14.0 milestone Sep 5, 2024
@straight-shoota straight-shoota merged commit 214d39a into crystal-lang:master Sep 6, 2024
@HertzDevil HertzDevil deleted the bug/windows-spec-c-dynamic branch September 6, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:bug A bug in the code. Does not apply to documentation, specs, etc. platform:windows Windows support based on the MSVC toolchain / Win32 API topic:compiler:codegen

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants