Remove XML::Error.errors#14936
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom Sep 18, 2024
Merged
Conversation
straight-shoota
added
kind:bug
Member
Author
|
There are no failures in |
ysbaddaden
approved these changes
Sep 5, 2024
beta-ziliani
reviewed
Sep 5, 2024
Co-authored-by: Beta Ziliani <beta@manas.tech>
beta-ziliani
approved these changes
Sep 6, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #14934
XML::Error.errorscollects all error messages from libxml2. Using it is deprecated, but without any calls to it, the error array is never cleared. So we're dropping it because it cannot be fixed. The new error mechanism based onXML::Reader#errorsis better in every regard.Closes #14966