Extract select from src/channel.cr#14912
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom Aug 18, 2024
Merged
Extract select from src/channel.cr#14912straight-shoota merged 2 commits intocrystal-lang:masterfrom
select from src/channel.cr#14912straight-shoota merged 2 commits intocrystal-lang:masterfrom
Conversation
Sija
reviewed
Aug 15, 2024
ysbaddaden
approved these changes
Aug 17, 2024
Collaborator
ysbaddaden
left a comment
ysbaddaden
left a comment
There was a problem hiding this comment.
Nice, it helps to focus on each concern 👍
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
selectis an independent feature and not directly related toChannel(although sending/receiving fromChannelis its main purpose).This patch extracts the implementation of
selectactions fromchannel.crinto separate files.It's a purely organizational refactor and does not involve any semantic changes. Everything stays in the
Channelnamespace.This is a preparatory step to make it easier to work on the code by separating concerns.