Fix misaligned store in Bool to union upcasts#14906
Merged
straight-shoota merged 3 commits intocrystal-lang:masterfrom Aug 15, 2024
Merged
Fix misaligned store in Bool to union upcasts#14906straight-shoota merged 3 commits intocrystal-lang:masterfrom
Bool to union upcasts#14906straight-shoota merged 3 commits intocrystal-lang:masterfrom
Conversation
HertzDevil
added
kind:bug
straight-shoota
approved these changes
Aug 14, 2024
ysbaddaden
approved these changes
Aug 15, 2024
straight-shoota
removed
the
kind:regression
straight-shoota
pushed a commit
that referenced
this pull request
Aug 20, 2024
The code path for `Nil` looks similar, but it is perfectly fine: it directly stores `[8 x i64] zeroinitializer` to the data field, whose default alignment naturally matches.
Merged
1 task
Collaborator
|
This pull request has been mentioned on Crystal Forum. There might be relevant details there: https://forum.crystal-lang.org/t/crystal-1-13-2-is-released/7110/1 |
Collaborator
|
This pull request has been mentioned on Crystal Forum. There might be relevant details there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14898.
The code path for
Nillooks similar, but it is perfectly fine: it directly stores[8 x i64] zeroinitializerto the data field, whose default alignment naturally matches.