Fix codegen spec for ProcPointer of virtual type#14903
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Aug 15, 2024
Merged
Fix codegen spec for ProcPointer of virtual type#14903straight-shoota merged 1 commit intocrystal-lang:masterfrom
ProcPointer of virtual type#14903straight-shoota merged 1 commit intocrystal-lang:masterfrom
Conversation
HertzDevil
added
kind:bug
straight-shoota
approved these changes
Aug 14, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec in #10964 is breaking the JIT because it is trying to return a
Proc, which comprises 2Void*s and therefore isn't supported byLLVM::GenericValue. The same would have happened if the spec were written like this:Turning it into a typed spec (#14090) gets rid of this implicit value.